Re: RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2]

2022-01-25 Thread Sean Mullan
On Mon, 24 Jan 2022 21:17:42 GMT, Hai-May Chao wrote: >> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 4908: >> >>> 4906: if (eMessage.contains("denyAfter constraint check >>> failed") && >>> 4907: e.getReason() == >>>

Re: RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2]

2022-01-24 Thread Hai-May Chao
On Mon, 24 Jan 2022 16:12:25 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update with review comments > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 4908: > >> 4906:

Re: RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2]

2022-01-24 Thread Sean Mullan
On Fri, 21 Jan 2022 03:34:24 GMT, Hai-May Chao wrote: >> `keytool` currently uses a simpler scheme in `DisabledAlgorithmConstraints` >> class when performing algorithm constraints checks. This change is to >> enhance `keytool` to make use of the new methods >>

Re: RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2]

2022-01-24 Thread Sean Mullan
On Fri, 21 Jan 2022 03:27:44 GMT, Hai-May Chao wrote: >> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1129: >> >>> 1127: } >>> 1128: >>> 1129: buildTrustedCerts(); >> >> Can we reuse the keystore loaded by `buildTrustedCerts()` instead of >> reloading

Re: RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2]

2022-01-20 Thread Hai-May Chao
> `keytool` currently uses a simpler scheme in `DisabledAlgorithmConstraints` > class when performing algorithm constraints checks. This change is to enhance > `keytool` to make use of the new methods > `DisabledAlgorithmConstraints.permits` with `CertPathConstraintsParameters` > and

Re: RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2]

2022-01-20 Thread Hai-May Chao
On Thu, 13 Jan 2022 16:31:35 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update with review comments > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 187: > >> 185: