Re: RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-30 Thread Jamil Nimeh
On Thu, 30 Sep 2021 01:22:56 GMT, Bradford Wetmore wrote: > See comment, + a couple minor cleanups. Looks good. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5765

Re: RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-30 Thread Jamil Nimeh
On Thu, 30 Sep 2021 14:15:59 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java line >> 153: >> >>> 151: private final byte[] label; >>> 152: >>> 153: SecretSchedule(String label) { >> >> Why are we opening the visibility on t

Re: RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-30 Thread Bradford Wetmore
On Thu, 30 Sep 2021 04:45:15 GMT, Jamil Nimeh wrote: >> See comment, + a couple minor cleanups. > > src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java line > 153: > >> 151: private final byte[] label; >> 152: >> 153: SecretSchedule(String label) { > > Why ar

Re: RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-29 Thread Jamil Nimeh
On Thu, 30 Sep 2021 01:22:56 GMT, Bradford Wetmore wrote: > See comment, + a couple minor cleanups. src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java line 153: > 151: private final byte[] label; > 152: > 153: SecretSchedule(String label) { Why are we openin

RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-29 Thread Bradford Wetmore
See comment, + a couple minor cleanups. - Commit messages: - Minor cleanup. Changes: https://git.openjdk.java.net/jdk/pull/5765/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5765&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274528 Stats: 13 lines in 1