On Wed, 3 Nov 2021 09:16:47 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOutp
I would suggest to fix in a separate bug.
Thanks,
Xuelei
> On Nov 3, 2021, at 2:27 PM, Daniel Jeliński wrote:
>
> On Wed, 3 Nov 2021 09:12:29 GMT, Daniel Jeliński
> wrote:
>
>>> src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java
>>> line 436:
>>>
434:
435:
On Wed, 3 Nov 2021 09:12:29 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java line
>> 436:
>>
>>> 434:
>>> 435: void queueUpCipherDispose() {
>>> 436: RecordMemo lastMemo = handshakeMemos.getLast();
>>
>> Sorry, I missed
On Wed, 3 Nov 2021 09:16:47 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOutp
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly
> [disposes the old
>
On Tue, 2 Nov 2021 23:43:42 GMT, Xue-Lei Andrew Fan wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> avoid modifying DTLSOutputRecord
>
> src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java li
On Tue, 2 Nov 2021 23:35:51 GMT, Xue-Lei Andrew Fan wrote:
> Please hold off on the integration, the regression testing failed.
could you point me to the failing test? I'm running the jdk_security suite;
only sun/security/mscapi/ShortRSAKeyWithinTLS is failing, and it's failing
because of envi
On Mon, 1 Nov 2021 20:38:32 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOutp
On Mon, 1 Nov 2021 20:38:32 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOutp
On Sun, 24 Oct 2021 04:58:45 GMT, Xue-Lei Andrew Fan wrote:
>> Did you want to cover the update for line 222 at OutputRecord.java as well?
>
>> After reviewing the scope of changes to fix writeCipher disposal I decided
>> to remove it entirely. It would probably be a nice follow-up enhancement,
On Mon, 1 Nov 2021 19:49:32 GMT, Xue-Lei Andrew Fan wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dispose write cipher after changing ciphers
>
> src/java.base/share/classes/sun/security/ssl/OutputRecord.java
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly
> [disposes the old
>
On Mon, 1 Nov 2021 14:13:43 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOutp
On Sun, 24 Oct 2021 04:58:45 GMT, Xue-Lei Andrew Fan wrote:
>> Did you want to cover the update for line 222 at OutputRecord.java as well?
>
>> After reviewing the scope of changes to fix writeCipher disposal I decided
>> to remove it entirely. It would probably be a nice follow-up enhancement,
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly
> [disposes the old
>
On Fri, 22 Oct 2021 18:45:31 GMT, Xue-Lei Andrew Fan wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLS
On Fri, 22 Oct 2021 18:45:31 GMT, Xue-Lei Andrew Fan wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLS
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly
> [disposes the old
>
On Fri, 22 Oct 2021 19:25:38 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOut
On Fri, 22 Oct 2021 18:45:31 GMT, Xue-Lei Andrew Fan wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLS
On Fri, 22 Oct 2021 19:25:38 GMT, Daniel Jeliński wrote:
>> The current code that changes cipher suites disposes the new suite instead
>> of the old one, which usually silently fails. This patch fixes the code to
>> dispose the old instance instead.
>>
>> DTLS appears to be unaffected: DTLSOut
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly
> [disposes the old
>
On Fri, 22 Oct 2021 18:24:22 GMT, Daniel Jeliński wrote:
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRe
On Fri, 22 Oct 2021 18:24:22 GMT, Daniel Jeliński wrote:
> The current code that changes cipher suites disposes the new suite instead of
> the old one, which usually silently fails. This patch fixes the code to
> dispose the old instance instead.
>
> DTLS appears to be unaffected: DTLSOutputRe
The current code that changes cipher suites disposes the new suite instead of
the old one, which usually silently fails. This patch fixes the code to dispose
the old instance instead.
DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly
[disposes the old
one](https://g
25 matches
Mail list logo
