Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v6]

2022-03-03 Thread Weijun Wang
On Thu, 3 Mar 2022 22:18:53 GMT, Hai-May Chao wrote: >> This fixes jarsigner to enforce checking against algorithm constraint >> properties so when the signature algorithms parameters use disabled or >> legacy algorithms, it will emit warnings accordingly. If the algorithm used >> in parameter

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v6]

2022-03-03 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned. Hai-M

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v4]

2022-03-03 Thread Hai-May Chao
On Thu, 3 Mar 2022 19:35:21 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused string > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line > 1418: > >> 1416:

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v5]

2022-03-03 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned. Hai-M

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v4]

2022-03-03 Thread Weijun Wang
On Thu, 3 Mar 2022 07:24:49 GMT, Hai-May Chao wrote: >> This fixes jarsigner to enforce checking against algorithm constraint >> properties so when the signature algorithms parameters use disabled or >> legacy algorithms, it will emit warnings accordingly. If the algorithm used >> in parameter

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v4]

2022-03-02 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned. Hai-M

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v3]

2022-03-02 Thread Hai-May Chao
On Wed, 2 Mar 2022 19:54:13 GMT, Weijun Wang wrote: >> What does it look like now? Also, you might need to create a mapping in >> `Resources.java` because "using" should only be shown when system language >> is English. > > Also, what if it's another algorithm using another type of parameters?

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v3]

2022-03-02 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned. Hai-M

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v2]

2022-03-02 Thread Weijun Wang
On Wed, 2 Mar 2022 18:01:04 GMT, Weijun Wang wrote: >> I add "RA-PSS using “ to the `-verbose` output as suggested, and keep >> the remaining output as the parameters for the RSASSA-PSS contain >> hashAlgorithm and maskGenAlgorithm that could be disabled or weak. At the >> same time, strip

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v2]

2022-03-02 Thread Weijun Wang
On Wed, 2 Mar 2022 17:46:26 GMT, Hai-May Chao wrote: >> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line >> 1414: >> >>> 1412: } catch (CertPathValidatorException e) { >>> 1413: disabledAlgFound = true; >>> 1414: return String

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v2]

2022-03-02 Thread Hai-May Chao
On Wed, 2 Mar 2022 16:20:53 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unneeded import and updated -verbose output > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.j

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v2]

2022-03-02 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned. Hai-M

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v2]

2022-03-02 Thread Hai-May Chao
On Wed, 2 Mar 2022 15:30:22 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unneeded import and updated -verbose output > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.j

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-03-02 Thread Weijun Wang
On Tue, 22 Feb 2022 22:00:05 GMT, Hai-May Chao wrote: > This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters i

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-03-02 Thread Weijun Wang
On Tue, 22 Feb 2022 22:00:05 GMT, Hai-May Chao wrote: > This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters i

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-03-02 Thread Weijun Wang
On Tue, 22 Feb 2022 22:00:05 GMT, Hai-May Chao wrote: > This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters i

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-03-02 Thread Sean Mullan
On Tue, 22 Feb 2022 22:00:05 GMT, Hai-May Chao wrote: > This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters i

RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-02-22 Thread Hai-May Chao
This fixes jarsigner to enforce checking against algorithm constraint properties so when the signature algorithms parameters use disabled or legacy algorithms, it will emit warnings accordingly. If the algorithm used in parameters is disabled, jarsigner treats the jar as unsigned. -

RFR: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-02-22 Thread Hai-May Chao
This fixes jarsigner to enforce checking against algorithm constraint properties so when the signature algorithms parameters use disabled or legacy algorithms, it will emit warnings accordingly. If the algorithm used in parameters is disabled, jarsigner treats the jar as unsigned. -