Re: RFR: 8282316: Operation before String case conversion [v3]

2022-02-23 Thread Xue-Lei Andrew Fan
> In the SignatureUtil implementation, the checkName() requires > case-insensitive input for "OID". However, the method is called before the > case conversion, for example: > > sigName = checkName(sigName).toUpperCase(Locale.ENGLISH); > > This update also clean up redundant calls

Re: RFR: 8282316: Operation before String case conversion [v2]

2022-02-23 Thread Xue-Lei Andrew Fan
On Wed, 23 Feb 2022 23:53:39 GMT, Weijun Wang wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> udpate return state as well > > src/java.base/share/classes/sun/security/util/SignatureUtil.java line 51: > >> 49

Re: RFR: 8282316: Operation before String case conversion [v2]

2022-02-23 Thread Weijun Wang
On Wed, 23 Feb 2022 23:41:36 GMT, Xue-Lei Andrew Fan wrote: >> In the SignatureUtil implementation, the checkName() requires >> case-insensitive input for "OID". However, the method is called before the >> case conversion, for example: >> >> sigName = checkName(sigName).toUpperCa

Re: RFR: 8282316: Operation before String case conversion [v2]

2022-02-23 Thread Xue-Lei Andrew Fan
> In the SignatureUtil implementation, the checkName() requires > case-insensitive input for "OID". However, the method is called before the > case conversion, for example: > > sigName = checkName(sigName).toUpperCase(Locale.ENGLISH); > > This update also clean up redundant calls

Re: RFR: 8282316: Operation before String case conversion

2022-02-23 Thread Xue-Lei Andrew Fan
On Wed, 23 Feb 2022 22:41:10 GMT, Valerie Peng wrote: >> In the SignatureUtil implementation, the checkName() requires >> case-insensitive input for "OID". However, the method is called before the >> case conversion, for example: >> >> sigName = checkName(sigName).toUpperCase(Loc

Re: RFR: 8282316: Operation before String case conversion

2022-02-23 Thread Valerie Peng
On Wed, 23 Feb 2022 19:25:10 GMT, Xue-Lei Andrew Fan wrote: > In the SignatureUtil implementation, the checkName() requires > case-insensitive input for "OID". However, the method is called before the > case conversion, for example: > > sigName = checkName(sigName).toUpperCase(Lo

RFR: 8282316: Operation before String case conversion

2022-02-23 Thread Xue-Lei Andrew Fan
In the SignatureUtil implementation, the checkName() requires case-insensitive input for "OID". However, the method is called before the case conversion, for example: sigName = checkName(sigName).toUpperCase(Locale.ENGLISH); This update also clean up redundant calls to the checkN