Re: RFR: 8284490: Remove finalizer method in java.security.jgss [v2]

2022-04-07 Thread Xue-Lei Andrew Fan
On Thu, 7 Apr 2022 17:35:47 GMT, Valerie Peng wrote: > Hmm, the earlier JCE change would also needs to be updated as it calls a > cleanup method on the to-be-cleaned object. Yes, I will check the cleaner used in the security components and make sure there is object reference problems.

Re: RFR: 8284490: Remove finalizer method in java.security.jgss [v2]

2022-04-07 Thread Valerie Peng
On Thu, 7 Apr 2022 15:48:50 GMT, Xue-Lei Andrew Fan wrote: >> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCredElement.java >> line 74: >> >>> 72: name = srcName; >>> 73: >>> 74: Cleaner.create().register(this, this::dispose); >> >> This will create a

Re: RFR: 8284490: Remove finalizer method in java.security.jgss [v2]

2022-04-07 Thread Xue-Lei Andrew Fan
> Please review the update to remove finalizer method in the java.security.jgss > module. It is one of the efforts to clean up the use of finalizer method in > JDK. Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: the object