Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v4]

2022-04-19 Thread Valerie Peng
> This trivial change is to deprecate the DEFAULT static field of > OAEPParameterSpec class. Wordings are mostly the same as the previous > PSSParameterSpec deprecation change. Rest are just minor code re-factoring. > > The CSR will be filed once review is somewhat finished. > > Thanks, >

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v3]

2022-04-19 Thread Valerie Peng
On Tue, 19 Apr 2022 19:54:24 GMT, Sean Mullan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed the private no-arg default constructor and minor javadoc update. > >

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v3]

2022-04-19 Thread Valerie Peng
On Tue, 19 Apr 2022 19:52:34 GMT, Sean Mullan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed the private no-arg default constructor and minor javadoc update. > >

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v3]

2022-04-19 Thread Sean Mullan
On Mon, 18 Apr 2022 23:36:56 GMT, Valerie Peng wrote: >> This trivial change is to deprecate the DEFAULT static field of >> OAEPParameterSpec class. Wordings are mostly the same as the previous >> PSSParameterSpec deprecation change. Rest are just minor code re-factoring. >> >> The CSR will

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v3]

2022-04-18 Thread Valerie Peng
> This trivial change is to deprecate the DEFAULT static field of > OAEPParameterSpec class. Wordings are mostly the same as the previous > PSSParameterSpec deprecation change. Rest are just minor code re-factoring. > > The CSR will be filed once review is somewhat finished. > > Thanks, >

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v2]

2022-04-18 Thread Sean Mullan
On Wed, 13 Apr 2022 19:27:00 GMT, Valerie Peng wrote: >> This trivial change is to deprecate the DEFAULT static field of >> OAEPParameterSpec class. Wordings are mostly the same as the previous >> PSSParameterSpec deprecation change. Rest are just minor code re-factoring. >> >> The CSR will

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v2]

2022-04-15 Thread Valerie Peng
On Wed, 13 Apr 2022 19:27:00 GMT, Valerie Peng wrote: >> This trivial change is to deprecate the DEFAULT static field of >> OAEPParameterSpec class. Wordings are mostly the same as the previous >> PSSParameterSpec deprecation change. Rest are just minor code re-factoring. >> >> The CSR will

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v2]

2022-04-14 Thread Sean Mullan
On Wed, 13 Apr 2022 19:27:00 GMT, Valerie Peng wrote: >> This trivial change is to deprecate the DEFAULT static field of >> OAEPParameterSpec class. Wordings are mostly the same as the previous >> PSSParameterSpec deprecation change. Rest are just minor code re-factoring. >> >> The CSR will

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec [v2]

2022-04-13 Thread Valerie Peng
> This trivial change is to deprecate the DEFAULT static field of > OAEPParameterSpec class. Wordings are mostly the same as the previous > PSSParameterSpec deprecation change. Rest are just minor code re-factoring. > > The CSR will be filed once review is somewhat finished. > > Thanks, >

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-13 Thread Sean Mullan
On Wed, 13 Apr 2022 18:28:33 GMT, Valerie Peng wrote: >> src/java.base/share/classes/javax/crypto/spec/OAEPParameterSpec.java line 81: >> >>> 79: * parameters for mgf -- MGF1ParameterSpec.SHA1 >>> 80: * source of encoding input -- PSource.PSpecified.DEFAULT >>> 81: * >> >> I think

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-13 Thread Valerie Peng
On Wed, 13 Apr 2022 15:35:38 GMT, Sean Mullan wrote: >> This trivial change is to deprecate the DEFAULT static field of >> OAEPParameterSpec class. Wordings are mostly the same as the previous >> PSSParameterSpec deprecation change. Rest are just minor code re-factoring. >> >> The CSR will be

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-13 Thread Valerie Peng
On Tue, 12 Apr 2022 01:27:35 GMT, Valerie Peng wrote: > This trivial change is to deprecate the DEFAULT static field of > OAEPParameterSpec class. Wordings are mostly the same as the previous > PSSParameterSpec deprecation change. Rest are just minor code re-factoring. > > The CSR will be

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-13 Thread Sean Mullan
On Tue, 12 Apr 2022 01:27:35 GMT, Valerie Peng wrote: > This trivial change is to deprecate the DEFAULT static field of > OAEPParameterSpec class. Wordings are mostly the same as the previous > PSSParameterSpec deprecation change. Rest are just minor code re-factoring. > > The CSR will be

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-12 Thread Sean Mullan
On Tue, 12 Apr 2022 02:48:51 GMT, Michael StJohns wrote: > I think deprecating DEFAULT? is wrong.? RFC8017 still has this definition: > > > RSAES-OAEP-params ::= SEQUENCE { > > hashAlgorithm [0] HashAlgorithm DEFAULT sha1, > > maskGenAlgorithm [1] MaskGenAlgorithm DEFAULT mgf1SHA1,

Re: RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-11 Thread Michael StJohns
On 4/11/2022 9:34 PM, Valerie Peng wrote: This trivial change is to deprecate the DEFAULT static field of OAEPParameterSpec class. Wordings are mostly the same as the previous PSSParameterSpec deprecation change. Rest are just minor code re-factoring. The CSR will be filed once review is

RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

2022-04-11 Thread Valerie Peng
This trivial change is to deprecate the DEFAULT static field of OAEPParameterSpec class. Wordings are mostly the same as the previous PSSParameterSpec deprecation change. Rest are just minor code re-factoring. The CSR will be filed once review is somewhat finished. Thanks, Valerie