Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4 [v2]

2022-04-26 Thread Weijun Wang
On Tue, 26 Apr 2022 16:02:41 GMT, Weijun Wang wrote: >> Compare encoded instead of decoded digest in RSA signature verification. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > only check digest value > _Mailing list messag

Re: [Internet]Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4 [v2]

2022-04-26 Thread xueleifan(XueleiFan)
With this update, is the purpose of this PR changed? The bug subject and description may need an update. Xuelei > On Apr 26, 2022, at 9:02 AM, Weijun Wang wrote: > >> Compare encoded instead of decoded digest in RSA signature verification. > > Weijun Wang has updated the pull request increme

Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4 [v2]

2022-04-26 Thread Weijun Wang
> Compare encoded instead of decoded digest in RSA signature verification. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: only check digest value - Changes: - all: https://git.openjdk.java.net/jdk/pull/8365/files - n

Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-24 Thread Weijun Wang
On Fri, 22 Apr 2022 23:20:43 GMT, Valerie Peng wrote: > Regardless whether we ended up with decode/encode, we should make sure > RSASSA-PSS signature impl is also covered and consistent. RSASSA-PSS is not affected. Neither with the PKCS11 RSA signature. - PR: https://git.openjdk.j

Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-23 Thread Xue-Lei Andrew Fan
On Fri, 22 Apr 2022 17:10:58 GMT, Weijun Wang wrote: > Compare encoded instead of decoded digest in RSA signature verification. src/java.base/share/classes/sun/security/rsa/RSASignature.java line 220: > 218: byte[] encoded = RSAUtil.encodeSignature(digestOID, digest); > 219:

Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-22 Thread Valerie Peng
On Fri, 22 Apr 2022 17:10:58 GMT, Weijun Wang wrote: > Compare encoded instead of decoded digest in RSA signature verification. Regardless whether we ended up with decode/encode, we should make sure RSASSA-PSS signature impl is also covered and consistent. - PR: https://git.openjd

Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-22 Thread Weijun Wang
On Fri, 22 Apr 2022 18:09:33 GMT, Michael StJohns wrote: > This is a weird one.? AFAICT the way it was being done is valid and > allowed by RFC8017 - I would have closed the bug report as notabug Yes, I saw the "Note". It's definitely OK to decode but one has to make sure the input is DER encod

Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-22 Thread Michael StJohns
On 4/22/2022 1:21 PM, Weijun Wang wrote: Compare encoded instead of decoded digest in RSA signature verification. - Commit messages: - RFC 8017 8.2.2 Step 4 Changes:https://git.openjdk.java.net/jdk/pull/8365/files Webrev:https://webrevs.openjdk.java.net/?repo=jdk&pr=8365&range=

RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-22 Thread Weijun Wang
Compare encoded instead of decoded digest in RSA signature verification. - Commit messages: - RFC 8017 8.2.2 Step 4 Changes: https://git.openjdk.java.net/jdk/pull/8365/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8365&range=00 Issue: https://bugs.openjdk.java.net/b