Re: RFR: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null [v2]

2022-04-27 Thread Xue-Lei Andrew Fan
On Wed, 27 Apr 2022 16:16:18 GMT, Daniel Jeliński wrote: >> Please review this follow up to #8349. >> >> As JCK pointed out, `permits` is supposed to throw IAE on null input. >> However, now that we're looking up the result in a `ConcurrentHashMap`, a >> `NullPointerException` is thrown. This

Re: RFR: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null [v2]

2022-04-27 Thread Daniel Jeliński
On Wed, 27 Apr 2022 15:37:27 GMT, Xue-Lei Andrew Fan wrote: > Maybe, the checking could be placed in permits() method (line 158-173) so > that it follows the spec, and easier to check. Good point! - PR: https://git.openjdk.java.net/jdk/pull/8427

Re: RFR: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null [v2]

2022-04-27 Thread Daniel Jeliński
> Please review this follow up to #8349. > > As JCK pointed out, `permits` is supposed to throw IAE on null input. > However, now that we're looking up the result in a `ConcurrentHashMap`, a > `NullPointerException` is thrown. This patch restores the original behavior. > > Verified that the