On Wed, 11 May 2022 16:39:18 GMT, Aleksey Shipilev wrote:
> > Thanks for reviewing. I'll let the GHA tests complete and integrate this
> > tomorrow if all is clear.
>
> I don't think GHA builds any microbenchmarks (because JMH is not enabled
> there), so there is no point to wait for those.
G
On Wed, 11 May 2022 16:00:42 GMT, Claes Redestad wrote:
> Thanks for reviewing. I'll let the GHA tests complete and integrate this
> tomorrow if all is clear.
I don't think GHA builds any microbenchmarks (because JMH is not enabled
there), so there is no point to wait for those.
-
On Wed, 11 May 2022 15:50:40 GMT, Claes Redestad wrote:
>> #8599 would add a new warning. This address the conversions in the
>> microbenchmark component by means of making the types precise or adding
>> explicit casts. There's quite a few changes in the ByteBuffers benchmarks,
>> but the real
On Wed, 11 May 2022 15:50:40 GMT, Claes Redestad wrote:
>> #8599 would add a new warning. This address the conversions in the
>> microbenchmark component by means of making the types precise or adding
>> explicit casts. There's quite a few changes in the ByteBuffers benchmarks,
>> but the real
On Wed, 11 May 2022 15:50:40 GMT, Claes Redestad wrote:
>> #8599 would add a new warning. This address the conversions in the
>> microbenchmark component by means of making the types precise or adding
>> explicit casts. There's quite a few changes in the ByteBuffers benchmarks,
>> but the real
On Wed, 11 May 2022 15:21:51 GMT, Aleksey Shipilev wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyrights, consistently use the exact accumulator type
>
> test/micro/org/openjdk/bench/vm/compiler/PointerBench
On Wed, 11 May 2022 15:47:29 GMT, Claes Redestad wrote:
>> #8599 would add a new warning. This address the conversions in the
>> microbenchmark component by means of making the types precise or adding
>> explicit casts. There's quite a few changes in the ByteBuffers benchmarks,
>> but the real
> #8599 would add a new warning. This address the conversions in the
> microbenchmark component by means of making the types precise or adding
> explicit casts. There's quite a few changes in the ByteBuffers benchmarks,
> but the real change is in the template as these are generated.
>
> I've r
