Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]

2022-06-09 Thread Weijun Wang
On Thu, 9 Jun 2022 22:29:36 GMT, Jamil Nimeh wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> verb > > src/java.base/share/classes/sun/security/util/math/IntegerModuloP.java line > 161: > >> 159: // This me

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]

2022-06-09 Thread Jamil Nimeh
On Thu, 9 Jun 2022 23:10:05 GMT, Weijun Wang wrote: >> Add comment to the method. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > verb Thanks, LGTM. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]

2022-06-09 Thread Weijun Wang
> Add comment to the method. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: verb - Changes: - all: https://git.openjdk.org/jdk/pull/9115/files - new: https://git.openjdk.org/jdk/pull/9115/files/36741bba..15ef85fe We

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0

2022-06-09 Thread Jamil Nimeh
On Thu, 9 Jun 2022 21:34:56 GMT, Weijun Wang wrote: > Add comment to the method. src/java.base/share/classes/sun/security/util/math/IntegerModuloP.java line 161: > 159: // This method is used in 2 cases: > 160: // 1. To calculate the inverse of a number in ECDSAOperations, > 161

RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0

2022-06-09 Thread Weijun Wang
Add comment to the method. - Commit messages: - add comment Changes: https://git.openjdk.org/jdk/pull/9115/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287178 Stats: 8 lines in 1 file changed: 7 ins; 0 del