On Wed, 2 Dec 2020 15:33:20 GMT, Jamil Nimeh wrote:
>> SunEC's algorithm name for keys are always "EdDSA", but I know BC returns
>> "Ed25519" or "Ed448".
>
> Filed and took ownership of JDK-8257607 to address BC JCE provider issues for
> both XDH and EdDSA when used with SunJSSE.
Also,
On Fri, 20 Nov 2020 20:05:09 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/ssl/JsseJce.java line 97:
>>
>>> 95: */
>>> 96: static final String SIGNATURE_EDDSA = "EdDSA";
>>> 97:
>>
>> Please update the copyright year.
>>
>> Is it possible that "ed25519" or
On Fri, 20 Nov 2020 20:22:33 GMT, Jamil Nimeh wrote:
>> src/java.base/share/classes/sun/security/ssl/CertificateRequest.java line
>> 139:
>>
>>> 137: if (cct.isAvailable) {
>>> 138: cct.keyAlgorithm.forEach(key -> {
>>> 139: if
On Fri, 20 Nov 2020 20:39:46 GMT, Xue-Lei Andrew Fan wrote:
>> JsseJce.isEcAvailable doesn't check for EdDSA availability so I'm not sure
>> we want that second clause. I don't think the EdDSA code is implemented in
>> the same module as the other EC code is so I don't know if we'd want to
On Fri, 20 Nov 2020 20:12:47 GMT, Jamil Nimeh wrote:
>> src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 73:
>>
>>> 71: ED448 (0x0808, "ed448", "Ed448",
>>> 72: "EdDSA",
>>> 73:
On Fri, 20 Nov 2020 19:58:23 GMT, Weijun Wang wrote:
>> Jamil Nimeh has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits
On Fri, 20 Nov 2020 18:37:36 GMT, Xue-Lei Andrew Fan wrote:
>> Jamil Nimeh has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Fri, 20 Nov 2020 17:31:20 GMT, Xue-Lei Andrew Fan wrote:
>> Jamil Nimeh has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Fri, 20 Nov 2020 18:09:26 GMT, Xue-Lei Andrew Fan wrote:
>> Jamil Nimeh has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Thu, 19 Nov 2020 17:48:34 GMT, Jamil Nimeh wrote:
>> Hello all,
>> This change brings in support for certificates with EdDSA keys (both Ed25519
>> and Ed448) allowing those signature algorithms to be used both on the
>> certificates themselves and used during the handshaking process for
On Thu, 19 Nov 2020 17:48:34 GMT, Jamil Nimeh wrote:
>> Hello all,
>> This change brings in support for certificates with EdDSA keys (both Ed25519
>> and Ed448) allowing those signature algorithms to be used both on the
>> certificates themselves and used during the handshaking process for
> Hello all,
> This change brings in support for certificates with EdDSA keys (both Ed25519
> and Ed448) allowing those signature algorithms to be used both on the
> certificates themselves and used during the handshaking process for messages
> like CertificateVerify, ServerKeyExchange and so
12 matches
Mail list logo
