Re: RFR: JDK-8186160 Fix a11y issues in java.security package

2017-08-14 Thread Brent Christian
FYI, I plan to fix this by way of: https://bugs.openjdk.java.net/browse/JDK-8186217 Remove erroneous @hidden JavaDoc tag from java.util.Properties.replace(Object, Object, Object) -Brent On 8/14/17 10:02 AM, Brent Christian wrote: Hi, Max This tag snuck in by mistake. Before pushing the fi

Re: RFR: JDK-8186160 Fix a11y issues in java.security package

2017-08-14 Thread Brent Christian
Hi, Max This tag snuck in by mistake. Before pushing the fix for JDK-8029891, we looked into ways to avoid addition of JavaDoc for all the trivial method overrides. I tried adding @hidden tags, but they didn't do what we wanted, so they were taken out. Except one - sorry about that. -Bren

Re: RFR: JDK-8186160 Fix a11y issues in java.security package

2017-08-14 Thread Weijun Wang
> > FWIW, there is one remaining issue to be addressed: it is a broken link in > Provider.html. > It comes from Provider.replace(Object, Object, Object) which overrides > Properties.replace(Object, Object, Object), but for some reason, that method > is > marked @hidden in Properties, causing a b

Re: RFR: JDK-8186160 Fix a11y issues in java.security package

2017-08-11 Thread Jonathan Gibbons
Brad, Thanks. I should have noted that the issues were detected by checking tools, and that after the edits, no such issues were reported in this package. FWIW, there is one remaining issue to be addressed: it is a broken link in Provider.html. It comes from Provider.replace(Object, Object, Ob

Re: RFR: JDK-8186160 Fix a11y issues in java.security package

2017-08-11 Thread Bradford Wetmore
Changes look good to me, although I'm not an HTML expert nor an expert in our current documentation style. I did compare the output, and can see the effects. (Striped, scope (row vs col), style) Brad On 8/11/2017 5:01 PM, Jonathan Gibbons wrote: Please review the following small fix for so

RFR: JDK-8186160 Fix a11y issues in java.security package

2017-08-11 Thread Jonathan Gibbons
Please review the following small fix for some accessibility issues in the java.security package. 3 tables are converted to the de-facto JDK standard for row-oriented tables, and updated with appropriate scope=row|col attributes to identify the header cell in each row or column. You can see t