Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-04 Thread Alan Bateman
On 04/10/2019 15:25, Eric Caspole wrote: Hi Alan, Here it is: http://cr.openjdk.java.net/~ecaspole/JDK-8215521/02/webrev/ Looks good.

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-04 Thread Claes Redestad
On 2019-10-04 16:25, Eric Caspole wrote: http://cr.openjdk.java.net/~ecaspole/JDK-8215521/02/webrev/ Looks good to me. /Claes

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-04 Thread Eric Caspole
Hi Alan, Here it is: http://cr.openjdk.java.net/~ecaspole/JDK-8215521/02/webrev/ thanks, Eric On 10/4/19 02:21, Alan Bateman wrote: On 03/10/2019 22:27, [email protected] wrote: : http://cr.openjdk.java.net/~ecaspole/JDK-8215521/01/webrev/ The cast is bit ugly. In other cases, we

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-03 Thread Alan Bateman
On 03/10/2019 22:27, [email protected] wrote: : http://cr.openjdk.java.net/~ecaspole/JDK-8215521/01/webrev/ The cast is bit ugly. In other cases, we create PrivilegedAction like the following to make it easier to read: PrivilegedAction pa = () -> AccessController.getContext(); ret

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-03 Thread eric . caspole
Oh thanks, I will fix it before pushing, Eric On 10/3/19 5:51 PM, Claes Redestad wrote: Hi Eric, benchmarks looks good to me! Nit: javadoc says "Benchmark measuring DoPrivileged", which doesn't look right. /Claes On 2019-10-03 23:27, [email protected] wrote: Hi everybody, Could I get

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-03 Thread Claes Redestad
Hi Eric, benchmarks looks good to me! Nit: javadoc says "Benchmark measuring DoPrivileged", which doesn't look right. /Claes On 2019-10-03 23:27, [email protected] wrote: Hi everybody, Could I get some reviews for JDK-8215521 to add a new JMH for AccessController.getContext() -- this w

RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

2019-10-03 Thread eric . caspole
Hi everybody, Could I get some reviews for JDK-8215521 to add a new JMH for AccessController.getContext() -- this was written by Dean after a bug from almost a year ago, then we forgot about it. I made the stack depth into a parameter. JBS: https://bugs.openjdk.java.net/browse/JDK-8215521 W