Re: RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-21 Thread Valerie Peng
Sure, webrev updated  and CSR moved to finalized state. http://cr.openjdk.java.net/~valeriep/8182484/webrev.02/ Thanks, Valerie On 11/21/2017 9:28 AM, Sean Mullan wrote: One more small comment:   51  * Check if the returned key pair generator is an instance of the   52  *

Re: RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-21 Thread Sean Mullan
One more small comment: 51 * Check if the returned key pair generator is an instance of the 52 * DSAKeyPairGenerator interface before casting the result to a I would just say "... instance of DSAKeyPairGenerator before ..." --Sean On 11/16/17 7:39 PM, Valerie Peng wrote: Thanks for

Re: RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-16 Thread Valerie Peng
Thanks for the feedback. I have updated webrev to address your comments: http://cr.openjdk.java.net/~valeriep/8182484/webrev.01/ CSR has also been updated and proposed. Valerie On 11/14/2017 10:47 AM, Sean Mullan wrote: On 11/8/17 6:47 PM, Valerie Peng wrote: Hi, Sean, I updated the

Re: RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-14 Thread Sean Mullan
On 11/8/17 6:47 PM, Valerie Peng wrote: Hi, Sean, I updated the webrev in place - now this change contains only javadoc update of DSAKeyPairGenerator interface. CSR has also been updated accordingly. Could you please take a look? Sure. 35 * DSAKeyPairGenerator, each provider must supply

Re: RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-08 Thread Valerie Peng
Hi, Sean, I updated the webrev in place - now this change contains only javadoc update of DSAKeyPairGenerator interface. CSR has also been updated accordingly. Could you please take a look? Thanks, Valerie On 11/2/2017 6:24 PM, Valerie Peng wrote: Sean, Could you help review this RFE

RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-02 Thread Valerie Peng
Sean, Could you help review this RFE below? It's mainly the javadoc update of java.security.interfaces.DSAKeyPairGenerator which replaces the 1024-bit default value with provider-specific one and removal of the earlier changes for working around this javadoc limitation. I reused the wordings