Rajan,
All of the tests I looked at have incorrectly modified copyright
information. Please fix and then I can push.
Copyright (c) 2005, 2006, Oracle and/or its affiliates. All rights reserved.
should be:
Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights reserved.
Not:
*
Looks fine to me. Thank you, Rajan!
Xuelei
On 3/18/2014 4:17 AM, Rajan Halade wrote:
> Thanks again! Updated review with corrections -
>
> http://cr.openjdk.java.net/~wetmore/8033271/webrev.03/
>
> - Rajan
>
> On 3/14/2014 18:36, Xuelei Fan wrote:
>> Minimal comments:
>>
>> test/sun/security/
Thanks again! Updated review with corrections -
http://cr.openjdk.java.net/~wetmore/8033271/webrev.03/
- Rajan
On 3/14/2014 18:36, Xuelei Fan wrote:
Minimal comments:
test/sun/security/smartcardio/TestAll.java
==
Looks like there is no actual update.
Minimal comments:
test/sun/security/smartcardio/TestAll.java
==
Looks like there is no actual update.
test/sun/security/smartcardio/*
===
- 32 //This test requires special hardware.
+ 32 // This test requires special hardware.
Thanks Xuelei for your comment. I updated all tests as per your suggestion -
http://cr.openjdk.java.net/~wetmore/8033271/webrev.02/
Please review again.
Thanks,
Rajan
On 3/14/2014 16:39, Xuelei Fan wrote:
I like the changes. I'm afraid the lines following the @summary tag will
be joined into o
I like the changes. I'm afraid the lines following the @summary tag will
be joined into one line during testing. We had such bad experiences in
a lot JSSE tests. Would you like put the manual testing comment into a
separated commend block?
For example, change the update
* @summary Ensure auth
Please review this fix:
http://cr.openjdk.java.net/~wetmore/8033271/webrev.01/
I removed @ignore from all these tests and marked them with manual for
now. These tests will be considered for automation as a separate effort
and will be executed manually for now.
Thanks,
Rajan
