The updated webrev looks good.
--Sean
On 07/10/2014 01:59 AM, Wang Weijun wrote:
Updated webrev at
http://cr.openjdk.java.net/~weijun/8043071/webrev.01/
All your suggestions accepted, plus
- New test on new classes added into KerberosHashEqualsTest.java
- A duplicate test/sun/security/k
Updated webrev at
http://cr.openjdk.java.net/~weijun/8043071/webrev.01/
All your suggestions accepted, plus
- New test on new classes added into KerberosHashEqualsTest.java
- A duplicate test/sun/security/krb5/auto/KerberosHashEqualsTest.java removed
- I don't know why KerberosKey allows a
On 07/09/2014 05:29 AM, Wang Weijun wrote:
On Jul 9, 2014, at 3:21, Sean Mullan wrote:
- several methods are now defined to throw IllegalStateExc, but you
(perhaps accidentally) removed the code that does that (ex:
getKeyType).
That's because KeyImpl.getKeyType() already throws it. I mentio
On Jul 9, 2014, at 3:21, Sean Mullan wrote:
> Hi Max,
>
> Here are my comments:
>
> * KerberosKey
>
> 37: Did you mean to use @link instead of @see?
Yes.
>
> - several methods are now defined to throw IllegalStateExc, but you (perhaps
> accidentally) removed the code that does that (ex: g
Hi Max,
Here are my comments:
* KerberosKey
37: Did you mean to use @link instead of @see?
- several methods are now defined to throw IllegalStateExc, but you
(perhaps accidentally) removed the code that does that (ex: getKeyType).
* KerberosTicket
352-3: put braces around the if (destroye
Hi All
Please review the change at
http://cr.openjdk.java.net/~weijun/8043071/webrev.00/
Two new inquire type KRB5_GET_SESSION_KEY_EX and KRB5_GET_KRB_CRED are added to
get the session key (in a new format) and the KRB_CRED message. Two new classes
are created as the types of their return va
