Re: RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

2015-04-23 Thread Sean Mullan
On 04/06/2015 04:18 PM, Florian Weimer wrote: On 03/04/2015 06:47 PM, Sean Mullan wrote: I can take care of filing an internal CCC and will let you know when that is approved or if there are any questions. This new webrev incorporates feedback from the CCC:

Re: RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

2015-04-06 Thread Florian Weimer
On 03/04/2015 06:47 PM, Sean Mullan wrote: > I can take care of filing an internal CCC and will let you know when > that is approved or if there are any questions. This new webrev incorporates feedback from the CCC: This needs additiona

Re: RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

2015-03-04 Thread Sean Mullan
On 03/02/2015 09:24 AM, Florian Weimer wrote: On 02/20/2015 11:23 PM, Sean Mullan wrote: On 02/17/2015 09:30 AM, Florian Weimer wrote: On 02/16/2015 11:13 PM, Sean Mullan wrote: Based on that, PolicyQualifierInfo should have implemented value-based equals() and hashCode(), and the identity-ba

Re: RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

2015-03-02 Thread Florian Weimer
On 02/20/2015 11:23 PM, Sean Mullan wrote: > On 02/17/2015 09:30 AM, Florian Weimer wrote: >> On 02/16/2015 11:13 PM, Sean Mullan wrote: >> Based on that, PolicyQualifierInfo should have implemented value-based equals() and hashCode(), and the identity-based set is just a bug. (But

Re: RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

2015-02-20 Thread Sean Mullan
On 02/17/2015 09:30 AM, Florian Weimer wrote: On 02/16/2015 11:13 PM, Sean Mullan wrote: Based on that, PolicyQualifierInfo should have implemented value-based equals() and hashCode(), and the identity-based set is just a bug. (But the requirement I cited is a stronger requirement the Set woul

RFR 8072394: java.security.cert.PolicyQualifierInfo needs value-based equality

2015-02-17 Thread Florian Weimer
On 02/16/2015 11:13 PM, Sean Mullan wrote: >> Based on that, PolicyQualifierInfo should have implemented value-based >> equals() and hashCode(), and the identity-based set is just a bug. (But >> the requirement I cited is a stronger requirement the Set would not >> enforce.) >> >> However, I thin