Re: RFR 8136425: KeystoreImpl.m using wrong type for cert format

2015-09-12 Thread Vincent Ryan
Your fix looks fine to me. Thanks. > On 12 Sep 2015, at 10:23, Wang Weijun wrote: > > Please take a look at > >http://cr.openjdk.java.net/~weijun/8136425/webrev.00/ > > > It looks like a wrong type is used, kSecFormatX509Cert and >

RFR 8136425: KeystoreImpl.m using wrong type for cert format

2015-09-12 Thread Wang Weijun
Please take a look at http://cr.openjdk.java.net/~weijun/8136425/webrev.00/ It looks like a wrong type is used, kSecFormatX509Cert and kSecFormatWrappedPKCS8 are of SecExternalFormat and the SecKeychainItemImport function also uses thi