Looks good, although the location of the new test (test/sun/security)
doesn't seem right. A new directory named test/conf/security would
probably make the most sense, but I think putting it in the new
test/jdk/security directory is also a better option.
--Sean
On 11/25/2015 09:36 PM, Wang Wei
> On Nov 25, 2015, at 11:04 PM, Sean Mullan wrote:
>
> The fix looks fine to me. For testing, can you create a test that uses a
> custom java.security file with "#ifndef solaris-sparc" in it, and check
> whether the property is used or not depending on what system is being tested?
The tool is
The fix looks fine to me. For testing, can you create a test that uses a
custom java.security file with "#ifndef solaris-sparc" in it, and check
whether the property is used or not depending on what system is being
tested?
--Sean
On 11/24/2015 06:10 AM, Magnus Ihse Bursie wrote:
On 2015-11-2
On 2015-11-20 02:12, Wang Weijun wrote:
Ding dong.
Even though this code resides in the make directory, it is not really
build code, so I cannot comment on it.
/Magnus
On Nov 9, 2015, at 3:35 PM, Wang Weijun wrote:
Hi All
Please review the code change at
http://cr.openjdk.java.net/~
Ding dong.
> On Nov 9, 2015, at 3:35 PM, Wang Weijun wrote:
>
> Hi All
>
> Please review the code change at
>
> http://cr.openjdk.java.net/~weijun/8141690/webrev.00/
>
> JDK-8133151 added support for "#ifdef solaris-sparc" but not "#ifndef
> solaris-spare". This is fixed and I also added "
Hi All
Please review the code change at
http://cr.openjdk.java.net/~weijun/8141690/webrev.00/
JDK-8133151 added support for "#ifdef solaris-sparc" but not "#ifndef
solaris-spare". This is fixed and I also added "#else".
How do I test the change?
Thanks
Max
