The updated webrev looks good~
Yes, I like to explicitly check the return value - it's quite easy with
OutputAnalyzer and doing so will mark first point of failure which saves
debugging time. New test classes look very good thanks to those test
library classes.
Thanks,
Valerie
On 4/10/2019 8
Hi Valerie,
Thanks for the review. Webrev updated at
https://cr.openjdk.java.net/~weijun/8180573/webrev.02/
You can look at the interdiff only.
> On Apr 11, 2019, at 5:29 AM, Valerie Peng wrote:
>
> Hi Max,
>
> Here are some comments/questions:
>
> General question, some of the tests use
Hi Max,
Here are some comments/questions:
General question, some of the tests use same name for keystore file,
i.e. ks. Will these tests interfere with each other at runtime? The
shell scripts often do some cleanup before starting the real test. I
assume we don't have to concern ourselves wit
Review took longer than I planned. Your fix looks good.
In addition to conversion to java, fix has good enhancements needed to
tests. For instance - changing non-default digest algorithm to SHA-1
from SHA-256 for AlgOptions.sh. Thanks for these changes.
Thanks,
Rajan
On 3/25/19 8:20 PM, Weij
Ding-dong.
> On Mar 5, 2019, at 8:26 AM, Weijun Wang wrote:
>
> Webrev updated at
>
> https://cr.openjdk.java.net/~weijun/8180573/webrev.01
>
> BTW, last time I mistakenly removed ExportPrivateKeyNoPwd.java which is used
> by ListKeychainStore.sh. It's now back.
>
> Thanks,
> Max
>
>> On
Webrev updated at
https://cr.openjdk.java.net/~weijun/8180573/webrev.01
BTW, last time I mistakenly removed ExportPrivateKeyNoPwd.java which is used by
ListKeychainStore.sh. It's now back.
Thanks,
Max
> On Feb 15, 2019, at 9:31 PM, Weijun Wang wrote:
>
> Hi Philipp,
>
> In most cases, it
Hi Philipp,
In most cases, it's just about creating a non-empty file; in some case, the
content is relevant. For the former, I will change it to something like "new
byte[10]"; for the latter, I'll use getBytes(UTF_8).
Thanks,
Max
> On Feb 15, 2019, at 5:34 PM, Philipp Kunz wrote:
>
> Hi Max
Hi Max,
I don't know if it is important enough, certainly not a serious issue.
In your patch, for example in DiffEnd.java and a few other tests,
Strings are encoded to byte streams with String.getBytes() which uses
the default platform character set to encode the strings.
Manifests, however, alway
Please review the fix at
https://cr.openjdk.java.net/~weijun/8180573/webrev.00/
Notes:
- Most changes are just .sh -> .java
- StorePasswordsByShell.sh combined into StorePasswords.java
- In most cases, JarUtils is called to create a jar file. Sometimes the jar
command is called because of
