Looks fine to me.
Mandy
> On Jun 19, 2017, at 6:17 AM, Weijun Wang wrote:
>
> Updated at http://cr.openjdk.java.net/~weijun/8182118/webrev.02/.
>
> --Max
>
> On 06/19/2017 08:23 PM, Sean Mullan wrote:
>> On 6/19/17 8:17 AM, Weijun Wang wrote:
There is more than one, so this should be "im
Your local workspace needs to be refreshed -- you are picking up an
older version of src/jdk.security.auth/share/classes/module-info.java
The module description after you apply your change should be:
* Provides implementations of the {@code javax.security.auth.*}
* interfaces and various auth
Updated at http://cr.openjdk.java.net/~weijun/8182118/webrev.02/.
--Max
On 06/19/2017 08:23 PM, Sean Mullan wrote:
On 6/19/17 8:17 AM, Weijun Wang wrote:
There is more than one, so this should be "implementations".
In fact, I originally used "implementations" (without "the") and "an
impleme
On 6/19/17 8:17 AM, Weijun Wang wrote:
There is more than one, so this should be "implementations".
In fact, I originally used "implementations" (without "the") and "an
implementation", but then I saw the module-info.java for the module
saying "Contains the implementation of the javax.securit
On 06/19/2017 07:52 PM, Sean Mullan wrote:
On 6/19/17 12:33 AM, Mandy Chung wrote:
On Jun 18, 2017, at 8:33 PM, Weijun Wang wrote:
Hi All
Please take a review at
http://cr.openjdk.java.net/~weijun/8182118/webrev.00/
Basically, a description line is added into package-info.java of eac
On 6/19/17 12:33 AM, Mandy Chung wrote:
On Jun 18, 2017, at 8:33 PM, Weijun Wang wrote:
Hi All
Please take a review at
http://cr.openjdk.java.net/~weijun/8182118/webrev.00/
Basically, a description line is added into package-info.java of each of these
packages:
- com/sun/security/auth
Updated at http://cr.openjdk.java.net/~weijun/8182118/webrev.01/.
I thought about using {@link java.security.Principal} but seems it's not
supported in package-info.java.
java/lang/package-info.java and many package summary use @link.
Looks like in my last try I only generated javadoc for
> On Jun 18, 2017, at 8:33 PM, Weijun Wang wrote:
>
> Hi All
>
> Please take a review at
>
> http://cr.openjdk.java.net/~weijun/8182118/webrev.00/
>
> Basically, a description line is added into package-info.java of each of
> these packages:
>
> - com/sun/security/auth:
>
> Contains the
Hi All
Please take a review at
http://cr.openjdk.java.net/~weijun/8182118/webrev.00/
Basically, a description line is added into package-info.java of each of
these packages:
- com/sun/security/auth:
Contains the implementation of {@code java.security.Principal}.
- com/sun/security/aut
