Re: [13] RFR 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

2019-07-09 Thread Xuelei Fan
I looked at the code a while back. It's good to me. Xuelei On 7/9/2019 7:35 AM, Weijun Wang wrote: Ping again. On Jul 2, 2019, at 10:51 AM, Weijun Wang wrote: "[13]" added to the subject. On Jul 2, 2019, at 10:22 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.

Re: [13] RFR 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

2019-07-09 Thread Weijun Wang
Ping again. > On Jul 2, 2019, at 10:51 AM, Weijun Wang wrote: > > "[13]" added to the subject. > >> On Jul 2, 2019, at 10:22 AM, Weijun Wang wrote: >> >> Please take a review at >> >> http://cr.openjdk.java.net/~weijun/8225687/webrev.00/ >> >> Most changes are around const usage in gssapi.

[13] RFR 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

2019-07-01 Thread Weijun Wang
"[13]" added to the subject. > On Jul 2, 2019, at 10:22 AM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8225687/webrev.00/ > > Most changes are around const usage in gssapi.h. Note that this is internal > so the change could only prevent any coding

RFR 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

2019-07-01 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8225687/webrev.00/ Most changes are around const usage in gssapi.h. Note that this is internal so the change could only prevent any coding error and will not be visible outside JDK. Other changes are inside gss_import_name(), gss_co