Thank you Seán!
Pushed.
On 11/12/19 12:35 AM, Seán Coffey wrote:
On 11/11/2019 20:56, Ivan Gerasimov wrote:
Thank you Seán for reviewing!
On 11/11/19 7:56 AM, Seán Coffey wrote:
Nice work Ivan.
I see you've some clean up done on exception handling also. I might
have a concern on this cha
On 11/11/2019 20:56, Ivan Gerasimov wrote:
Thank you Seán for reviewing!
On 11/11/19 7:56 AM, Seán Coffey wrote:
Nice work Ivan.
I see you've some clean up done on exception handling also. I might
have a concern on this change in SSLLogger. You're catching
IOException now instead of Except
Thank you Seán for reviewing!
On 11/11/19 7:56 AM, Seán Coffey wrote:
Nice work Ivan.
I see you've some clean up done on exception handling also. I might
have a concern on this change in SSLLogger. You're catching
IOException now instead of Exception. Given that it's a logger and the
intent
Nice work Ivan.
I see you've some clean up done on exception handling also. I might have
a concern on this change in SSLLogger. You're catching IOException now
instead of Exception. Given that it's a logger and the intent seems to
be to ignore any type of exception - should we leave what's the
Hello!
There are many places in the security libraries where string are
converted from/to byte arrays using standard charsets.
It would be beneficial, if those are not looked up by their name every
time, and constants from java.nio.charset.StandardCharsets.* are used
instead.
Would you ple
