Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-05-04 Thread Weijun Wang
Yes, please. Thanks, Max > On May 5, 2020, at 11:58 AM, Martin Balao wrote: > > Hi Max, > > On 3/30/20 5:24 PM, Martin Balao wrote: >> >> CSR requested here: https://bugs.openjdk.java.net/browse/JDK-8241871 >> > > Now that the CSR has been approved, are we good to push? > > Thanks, >

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-05-04 Thread Martin Balao
Hi Max, On 3/30/20 5:24 PM, Martin Balao wrote: > > CSR requested here: https://bugs.openjdk.java.net/browse/JDK-8241871 > Now that the CSR has been approved, are we good to push? Thanks, Martin.-

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-31 Thread Weijun Wang
> On Apr 1, 2020, at 8:22 AM, Martin Balao wrote: > > Hi Max, > > Thanks for having a look at the CSR. > > On 3/30/20 11:39 PM, Weijun Wang wrote: >> 1. I don't think there is a need to talk about the java.security.krb5.conf >> system property, the krb5.conf file name is more popular. >>

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-31 Thread Martin Balao
Hi Max, Thanks for having a look at the CSR. On 3/30/20 11:39 PM, Weijun Wang wrote: > 1. I don't think there is a need to talk about the java.security.krb5.conf > system property, the krb5.conf file name is more popular. > Added a reference to the krb5.conf file in the first place. I wish we

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-30 Thread Weijun Wang
1. I don't think there is a need to talk about the java.security.krb5.conf system property, the krb5.conf file name is more popular. 2. I'd rather always say "TGS requests" instead of "AP requests". Thanks, Max > On Mar 31, 2020, at 4:24 AM, Martin Balao wrote: > > Hi Max, > > CSR requested

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-30 Thread Martin Balao
Hi Max, CSR requested here: https://bugs.openjdk.java.net/browse/JDK-8241871 Look forward to your comments or approval there. Thanks, Martin.-

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-30 Thread Martin Balao
Hi Max, Thanks for having a look at this. On 3/29/20 1:10 AM, Weijun Wang wrote: >> * Note: from a client side, sending an NT-ENTERPRISE cname means that >> the cname can change in the response. Windows AD 2016, however, does not >> change it unless 'canonicalize' flag is explicitly set in the

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-28 Thread Weijun Wang
The change looks good to me. > On Mar 29, 2020, at 8:12 AM, Martin Balao wrote: > > * http://cr.openjdk.java.net/~mbalao/webrevs/8239385/8239385.webrev.00/ > ... > * Note: from a client side, sending an NT-ENTERPRISE cname means that > the cname can change in the response. Windows AD 2016,

RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-28 Thread Martin Balao
Hi Max, I'd like to propose a fix for 8239385 [1]. Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8239385/8239385.webrev.00/ The goal behind these changes is to align the Kerberos client default 'canonicalize' behavior to the MIT's one -an analysis of the latter is available at the