Re: RFR JDK-8003245

2013-06-25 Thread John Zavgren
Greetings: I made a change to src/share/native/sun/security/pkcs11/wrapper/p11_convert.c... I replaced all the code that looks like this: struct fubar bar; memset(&bar, 0, sizeof(struct fubar)); with code that looks like this: struct fubar bar = {0}; Also, I looked for similar usage patter

Re: RFR JDK-8003245

2013-06-19 Thread Anthony Scarpino
Hi, There maybe some cross platform issues I'm not familiar with, but you can just zero the structure when it's defined. CK_SSL3_MASTER_KEY_DERIVE_PARAMS ckParams = {0}; Tony On 06/18/2013 07:27 PM, John Zavgren wrote: Greetings: Please consider the following changes that eliminate the

Re: RFR JDK-8003245

2013-06-19 Thread Valerie (Yu-Ching) Peng
John, Just wondering that if you have checked other PKCS11 native code in the same directory for similar problems? It seems to me that at least p11_crypt.c, p11_digest.c, p11_general.c, also contains similar usage pattern. Thanks, Valerie On 06/18/13 19:27, John Zavgren wrote: Greetings:

RFR JDK-8003245

2013-06-18 Thread John Zavgren
Greetings: Please consider the following changes that eliminate the use of uninitialized memory. http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ Thanks! John

Re: RFR JDK-8003245

2013-05-30 Thread Chris Hegarty
>GetFieldID(env, jX942Dh1DeriveParamsClass, "kdf", "J"); if (fieldID == NULL) { return ckParam; } - Original Message - From: fwei...@redhat.com To: john.zavg...@oracle.com Cc: core-libs-...@openjdk.java.net Sent: Wednesday, March 27, 2013 11:48:57 AM GMT -05:00 US/Canada Eastern Subject: