Looks fine to me now.
Thanks,
Valerie
On 06/13/13 05:35, John Zavgren wrote:
All:
Please give this change one more consideration.
Thanks!
John
Original Message
Subject:Re: Re: RFR JDK-8014307
Date: Fri, 24 May 2013 15:56:11 -0400
From: John Zavgren
To
Looks ok to me John.
-Chris.
On 06/13/2013 01:35 PM, John Zavgren wrote:
All:
Please give this change one more consideration.
Thanks!
John
Original Message
Subject:Re: Re: RFR JDK-8014307
Date: Fri, 24 May 2013 15:56:11 -0400
From: John Zavgren
To
All:
Please give this change one more consideration.
Thanks!
John
Original Message
Subject:Re: Re: RFR JDK-8014307
Date: Fri, 24 May 2013 15:56:11 -0400
From: John Zavgren
To: Security-Dev
Thanks, Valerie. I removed the unnecessary resetGSSBuffer
Thanks, Valerie. I removed the unnecessary resetGSSBuffer(...) call. The
revised webrev is viewable at:
http://cr.openjdk.java.net/~jzavgren/8014307/webrev.03/
<http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.03/>
John
Original Message
Subject: Re: RFR JDK-8
The resetGSSBuffer(..) call on line 829 should be removed as the inToken
structure isn't even initialized yet (initGSSBuffer call is on line 833).
Rest looks fine.
Thanks,
Valerie
On 05/22/13 11:54, John Zavgren wrote:
Greetings:
I just updated:
/jdk/src/share/native/sun/security/jgss/wrapper/G
Greetings:
I just updated:
/jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
/with the recommended changes.
http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/
Thanks!
John Zavgren
--
John,
1) 332-333 can be re
John,
1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with
this deleteGSSOID(nameType) call, we should also add the following line:
resetGSSBuffer(env, jnameVal, &nameVal);
2) I think the ExceptionCheck block on line 932 should also be enhanced
w/ resetGSSBuffer(env, j
Greetings:
Please review the following change to the file:
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that fixes two
memory leaks.
http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/
Thanks!
John Zavgren
