Re: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-19 Thread Weijun Wang
ssage- > From: Weijun Wang > Sent: Thursday, January 11, 2018 11:33 AM > To: Sibabrata Sahoo > Cc: security-dev@openjdk.java.net > Subject: Re: [11] RFR: 8194486: Several krb5 tests failed in Mac. > > > >> On Jan 11, 2018, at 1:30 PM, Sibabrata Sahoo >>

RE: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-17 Thread Sibabrata Sahoo
- > From: Weijun Wang > Sent: Wednesday, January 10, 2018 9:07 PM > To: Sibabrata Sahoo > Cc: security-dev@openjdk.java.net > Subject: Re: [11] RFR: 8194486: Several krb5 tests failed in Mac. > > Code change looks fine. I think you can safely remove the lines commented > o

Re: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-10 Thread Weijun Wang
Wang > Sent: Wednesday, January 10, 2018 9:07 PM > To: Sibabrata Sahoo > Cc: security-dev@openjdk.java.net > Subject: Re: [11] RFR: 8194486: Several krb5 tests failed in Mac. > > Code change looks fine. I think you can safely remove the lines commented > out. If you meant

RE: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-10 Thread Sibabrata Sahoo
I will remove the commented lines. I think, it should be fine, if I do not submit the webrev again. Thanks, Siba -Original Message- From: Weijun Wang Sent: Wednesday, January 10, 2018 9:07 PM To: Sibabrata Sahoo Cc: security-dev@openjdk.java.net Subject: Re: [11] RFR: 8194486: Several

Re: [11] RFR: 8194486: Several krb5 tests failed in Mac.

2018-01-10 Thread Weijun Wang
Code change looks fine. I think you can safely remove the lines commented out. If you meant to keep the history, the Mercurial repo already had it. Thanks Max > On Jan 10, 2018, at 8:58 PM, Sibabrata Sahoo > wrote: > > Hi, > > Please review the change for the following patch, > > JBS: htt