Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-04 Thread Valerie Peng
Thanks for the review~ Valerie On 9/4/2015 8:20 AM, Anthony Scarpino wrote: Ok. The changes looks good. Thanks for looking into it and changing the bug synopsis. Tony On Sep 3, 2015, at 4:25 PM, Valerie Peng wrote: For all the JavaCritical calls, it's impossible to have the combination o

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-04 Thread Anthony Scarpino
Ok. The changes looks good. Thanks for looking into it and changing the bug synopsis. Tony > On Sep 3, 2015, at 4:25 PM, Valerie Peng wrote: > > > For all the JavaCritical calls, it's impossible to have the combination of > (bufOut==NULL && outLen!=0) as the outLen value is generated by VM

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-03 Thread Valerie Peng
For all the JavaCritical calls, it's impossible to have the combination of (bufOut==NULL && outLen!=0) as the outLen value is generated by VM based on bufOut. Anyway, just to play it safe, I added a line to set outLen to 0 just to match what is done for line 657. http://cr.openjdk.java.net/~

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-03 Thread Valerie Peng
Alright, I will update the synopsis. I am not exactly sure if it's GCM only as CipherFinal() call is used for all Ucrypto encryption/decryption. The testcase is using AES/GCM, but I am not sure if the underlying native code which has the problem is GCM specific. The using outLen's reference a

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-03 Thread Anthony Scarpino
> On Sep 2, 2015, at 10:50 PM, Anthony Scarpino > wrote: > > >> On Sep 2, 2015, at 3:45 PM, Valerie Peng wrote: >> >> >> Can someone help review this java workaround for Solaris memory leak bug in >> Ucrypto library? >> Essentially, the memory leak occurs when a null output buffer is speci

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-02 Thread Anthony Scarpino
> On Sep 2, 2015, at 3:45 PM, Valerie Peng wrote: > > > Can someone help review this java workaround for Solaris memory leak bug in > Ucrypto library? > Essentially, the memory leak occurs when a null output buffer is specified > when doing encryption/decryption. > So, the workaround in Oracl