Re: [PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-27 Thread Valerie Peng
The later version looks good and I will use this one. Thanks, Valerie On 2/22/2018 2:49 AM, Jan Kalina wrote: Ok, thanks Valerie! Sorry for spam, I has supposed my previous email was not considered to be patch. Martin: As this is way how it is initialized in other places, I has not consider

Re: [PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-22 Thread Jan Kalina
Ok, thanks Valerie! Sorry for spam, I has supposed my previous email was not considered to be patch. Martin: As this is way how it is initialized in other places, I has not considered it. http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/59e88d3b9b17/src/share/native/sun/security/jgss/wrapper/GSSLibSt

Re: [PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-21 Thread Valerie Peng
I have this on my to-do-list and will include this for the next release, JDK 11, whose release date is Nov this year. Thanks, Valerie On 2/21/2018 8:39 AM, Jan Kalina wrote: I has prepared fix for bug related to using native GSS API. Uninitialized fields causes JVM crash or authentication faili

Re: [PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-21 Thread Martin Balao
Have you considered zeroizing the whole "gss_channel_bindings_t" structure with memset? So we don't have problem if new fields are eventually added. On Wed, Feb 21, 2018 at 1:39 PM, Jan Kalina wrote: > I has prepared fix for bug related to using native GSS API. > Uninitialized fields causes JVM