Re: 8245686: Ed25519 and Ed448 present in handshake messages

2020-06-09 Thread Anthony Scarpino
Thanks for the comment.. I moved the code up toward the top. Tony On 6/9/20 4:04 PM, Xuelei Fan wrote: A simple fix like this looks good to me.  I may check this first, before the EC available and signature checking. Xuelei On 6/9/2020 3:12 PM, Anthony Scarpino wrote: Hi, I need a code rev

Re: 8245686: Ed25519 and Ed448 present in handshake messages

2020-06-09 Thread Anthony Scarpino
Thanks for catching that. Tony On 6/9/20 5:23 PM, Bradford Wetmore wrote: Update the year, but otherwise looks good. Brad On 6/9/2020 4:04 PM, Xuelei Fan wrote: A simple fix like this looks good to me.  I may check this first, before the EC available and signature checking. Xuelei On 6/9

Re: 8245686: Ed25519 and Ed448 present in handshake messages

2020-06-09 Thread Bradford Wetmore
Update the year, but otherwise looks good. Brad On 6/9/2020 4:04 PM, Xuelei Fan wrote: A simple fix like this looks good to me.  I may check this first, before the EC available and signature checking. Xuelei On 6/9/2020 3:12 PM, Anthony Scarpino wrote: Hi, I need a code review of this ver

Re: 8245686: Ed25519 and Ed448 present in handshake messages

2020-06-09 Thread Xuelei Fan
A simple fix like this looks good to me. I may check this first, before the EC available and signature checking. Xuelei On 6/9/2020 3:12 PM, Anthony Scarpino wrote: Hi, I need a code review of this very simple change for a situation that I'm not sure is a problem in the real world. The or

Re: 8245686: Ed25519 and Ed448 present in handshake messages

2020-06-09 Thread Jamil Nimeh
Looks fine to me. --Jamil On 6/9/2020 3:12 PM, Anthony Scarpino wrote: Hi, I need a code review of this very simple change for a situation that I'm not sure is a problem in the real world. The original TLS 1.3 putback added EdDSA to the TLS signature extensions enumeration before there was