Re: Code Review Request 6203816 and 6720456

2010-11-30 Thread Brad Wetmore
> For the TBD tests, we sort of just let them run, i.e. through the > getInstance(), init(..), generateKey(), and don't enforce the actual > result to match the expected result. Hm...that's unfortunate. I guess I don't see a better way to do it either. http://cr.openjdk.java.net/~valeriep/67204

Re: Code Review Request 6203816 and 6720456

2010-11-19 Thread Weijun Wang
I'm fine with all code changes. Thanks Max On 11/20/2010 08:00 AM, Valerie (Yu-Ching) Peng wrote: On 11/17/10 19:31, Weijun Wang wrote: On 11/18/2010 11:00 AM, Valerie (Yu-Ching) Peng wrote: Thanks for the lightning fast review! TBD means "to be determined at runtime". Different machines w

Re: Code Review Request 6203816 and 6720456

2010-11-19 Thread Valerie (Yu-Ching) Peng
Great, thanks for the confirmation... Valerie On 11/19/10 16:45, Weijun Wang wrote: I'm fine with all code changes. Thanks Max On 11/20/2010 08:00 AM, Valerie (Yu-Ching) Peng wrote: On 11/17/10 19:31, Weijun Wang wrote: On 11/18/2010 11:00 AM, Valerie (Yu-Ching) Peng wrote: Thanks for th

Re: Code Review Request 6203816 and 6720456

2010-11-19 Thread Valerie (Yu-Ching) Peng
On 11/17/10 19:31, Weijun Wang wrote: On 11/18/2010 11:00 AM, Valerie (Yu-Ching) Peng wrote: Thanks for the lightning fast review! TBD means "to be determined at runtime". Different machines w/ different versions of Solaris may support different key sizes. So, I use TBD to indicate the key siz

Re: Code Review Request 6203816 and 6720456

2010-11-18 Thread Weijun Wang
On 11/18/2010 11:00 AM, Valerie (Yu-Ching) Peng wrote: Thanks for the lightning fast review! TBD means "to be determined at runtime". Different machines w/ different versions of Solaris may support different key sizes. So, I use TBD to indicate the key sizes which may only be supported by the

Re: Code Review Request 6203816 and 6720456

2010-11-17 Thread Valerie (Yu-Ching) Peng
Thanks for the lightning fast review! TBD means "to be determined at runtime". Different machines w/ different versions of Solaris may support different key sizes. So, I use TBD to indicate the key sizes which may only be supported by the newer versions of Solairs release. I thought you are

Re: Code Review Request 6203816 and 6720456

2010-11-17 Thread Weijun Wang
On 11/18/2010 07:31 AM, Valerie (Yu-Ching) Peng wrote: Hi, Max, Can you please help reviewing the following two regression test fixes? 6203816: Can not run test/java/security/Security/ClassLoaderDeadlock.sh from the command line Webrev: http://cr.openjdk.java.net/~valeriep/6203816/webrev.00/