Re: JDK 9 RFR of JDK-8146745: Problem list SessionCacheSizeTests.java

2016-01-10 Thread Xuelei Fan
On 1/11/2016 10:50 AM, joe darcy wrote: > Hi Xuelei, > > I'm not a concurrency expert, but I don't think it is proper to only > synchronize on the writing of a data structure -- the reading should be > synchronized too. > Yes. The fix considered the reading side too. The reading of the serverPo

Re: JDK 9 RFR of JDK-8146745: Problem list SessionCacheSizeTests.java

2016-01-10 Thread joe darcy
Hi Xuelei, I'm not a concurrency expert, but I don't think it is proper to only synchronize on the writing of a data structure -- the reading should be synchronized too. Have you reproduced the failure with the code and seen the failure go away with the new code? Is there a hypothesis on why

Re: JDK 9 RFR of JDK-8146745: Problem list SessionCacheSizeTests.java

2016-01-10 Thread Xuelei Fan
Looks fine to me. BTW, the fix for JDK-8146387 is asking for code review. http://mail.openjdk.java.net/pipermail/security-dev/2016-January/013301.html Thanks, Xuelei On 1/11/2016 4:54 AM, joe darcy wrote: > Hello, > > The test > > javax/net/ssl/SSLSession/SessionCacheSizeTests.java > > has b