Re: JDK 9 Review Request for 8046949: Generify the javax.xml.crypto API

2014-11-11 Thread Sean Mullan
On 11/10/2014 10:33 PM, Xuelei Fan wrote: Looks fine to me. A pretty minor comment. share/classes/javax/xml/crypto/dsig/spec/XPathType.java --- 157 this.expression = expression; 158 this.filter = filter; 159 if (namespaceMap == null) { 160

Re: JDK 9 Review Request for 8046949: Generify the javax.xml.crypto API

2014-11-10 Thread Xuelei Fan
Looks fine to me. A pretty minor comment. share/classes/javax/xml/crypto/dsig/spec/XPathType.java --- 157 this.expression = expression; 158 this.filter = filter; 159 if (namespaceMap == null) { 160 throw new NullPointerException("namespa