Re: JDK8 Code review request for 7199939 and 7199941

2012-09-25 Thread Vincent Ryan
Understood. Fixes look good. On 24/09/2012 21:27, Valerie (Yu-Ching) Peng wrote: Vinnie, Thanks for the comment! The reason that I use "<" instead of "<=" on line 150 is because that (1024, 160) is supported by the DSAGenParameterSpec class and thus I didn't view this as legacy value. Either in

Re: JDK8 Code review request for 7199939 and 7199941

2012-09-24 Thread Valerie (Yu-Ching) Peng
Vinnie, Thanks for the comment! The reason that I use "<" instead of "<=" on line 150 is because that (1024, 160) is supported by the DSAGenParameterSpec class and thus I didn't view this as legacy value. Either init(...) calls should work for 1024, so I'd like to use the newer form of init(..

Re: JDK8 Code review request for 7199939 and 7199941

2012-09-24 Thread Vincent Ryan
Fixes look good. Just a minor comment at l.150 of ParameterCache: the test could use '<='?? On 22 Sep 2012, at 00:45, Valerie (Yu-Ching) Peng wrote: > Hi, Vinnie, > > Can you please review these following 2 JDK8 fixes? They are straight forward > regressions found by SQE tests introduced as byp