Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Wei-Jun Wang
See https://github.com/openjdk/jdk/pull/5176. The krb5 debug warning is also quite verbose and I think it’s not worth printing out the whole stack trace. Also, no existing debug message starts with “WARNING". They are just plain flat text. Thanks, Weijun > On Aug 18, 2021, at 5:34 PM, Horváth

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Horváth Péter Gergely
OK, I think we can agree on that. Please add the changes of KeyTab.java: it should be helpful in future releases. Thanks, Peter On Wed, Aug 18, 2021, 23:06 Wei-Jun Wang, wrote: > I think the new message in KeyTab.java is enough. The added lines in > Krb5LoginModule is a little too long with the

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Wei-Jun Wang
I think the new message in KeyTab.java is enough. The added lines in Krb5LoginModule is a little too long with the try-catch structure. —Weijun > On Aug 18, 2021, at 1:50 PM, Horváth Péter Gergely > wrote: > > Hi Weijun, > > Many thanks for your response. I think that indeed it would make se

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Horváth Péter Gergely
Hi Weijun, Many thanks for your response. I think that indeed it would make sense to log in KeyTab, since the FileNotFoundException there should even have the platform-specific reason message coming from the native layer. At the same time, I think it would make sense to emit a log message around

Re: Logging missing keytab file in Krb5LoginModule

2021-08-17 Thread Wei-Jun Wang
How do you think if we add some debug info at the internal KeyTab creation at [1]? For the 2 exceptions we can print out a line and the exception.toString(), then you will know if the filename doesn’t exist, or is a directory, or no permission to read. Of course, you will need to turn on -Dsun