Re: RFR: 8150530:Improve javax.crypto.BadPaddingException messages

2016-08-24 Thread Seán Coffey
Thanks for the review Xuelei. OK - I'll drop the 'password' reference then and push the changes. ! throw new BadPaddingException("Given final block not " + ! "properly padded. Such issues could arise if a bad key " + ! "is used durin

Re: RFR: 8150530:Improve javax.crypto.BadPaddingException messages

2016-08-24 Thread Xuelei Fan
On 8/24/2016 7:02 PM, Seán Coffey wrote: On 22/08/16 11:06, Xuelei Fan wrote: Minor comments: CipherCore.java --- "... could arise if a bad key or password is used during decryption." "password" may be confusing for some user cases. This could also happen if bad key used for encry

Re: RFR: 8150530:Improve javax.crypto.BadPaddingException messages

2016-08-24 Thread Seán Coffey
On 22/08/16 11:06, Xuelei Fan wrote: Minor comments: CipherCore.java --- "... could arise if a bad key or password is used during decryption." "password" may be confusing for some user cases. This could also happen if bad key used for encryption. I may just say "could arise if a

Re: RFR: 8150530:Improve javax.crypto.BadPaddingException messages

2016-08-22 Thread Xuelei Fan
Minor comments: CipherCore.java --- "... could arise if a bad key or password is used during decryption." "password" may be confusing for some user cases. This could also happen if bad key used for encryption. I may just say "could arise if a bad key used." RSAPadding.java -