Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-21 Thread Chris Hegarty
On 20 Apr 2016, at 20:34, Claes Redestad wrote: > > > On 2016-04-20 20:51, Chris Hegarty wrote: >> On 20 Apr 2016, at 15:44, Claes Redestad wrote: >> >>> Hello, >>> >>> now that the sun.security.action package is encapsulated we can simplify >>> internal code to get System properties. >>>

Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-20 Thread Claes Redestad
On 2016-04-20 20:51, Chris Hegarty wrote: On 20 Apr 2016, at 15:44, Claes Redestad wrote: Hello, now that the sun.security.action package is encapsulated we can simplify internal code to get System properties. Bug: https://bugs.openjdk.java.net/browse/JDK-8154231 Webrev: http://cr.openjdk

Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-20 Thread Chris Hegarty
On 20 Apr 2016, at 15:44, Claes Redestad wrote: > Hello, > > now that the sun.security.action package is encapsulated we can simplify > internal code to get System properties. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8154231 > Webrev: http://cr.openjdk.java.net/~redestad/8154231/webr

Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-20 Thread Claes Redestad
On 2016-04-20 16:58, Wang Weijun wrote: This is quite convenient. Glad you like it! We not cover the other modules? exports sun.security.action to java.desktop, java.security.jgss, jdk.crypto.pkcs11; I was worried I included too many changes in this patch as

Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-20 Thread Ulf Zibis
Hi Claes, thanks. Am 20.04.2016 um 18:12 schrieb Claes Redestad: Thanks for looking at this, Ulf! - Isn't the "theProp" naming style something from an old usage where all members have been named myXyz? I more would like "propName" or just "property". I chose to go with keeping names in line

Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-20 Thread Claes Redestad
Thanks for looking at this, Ulf! On 2016-04-20 17:57, Ulf Zibis wrote: Hi, here my comments: Am 20.04.2016 um 16:44 schrieb Claes Redestad: Hello, now that the sun.security.action package is encapsulated we can simplify internal code to get System properties. Bug: https://bugs.openjdk.jav

Re: RFR: 8154231: Simplify access to System properties from JDK code

2016-04-20 Thread Wang Weijun
This is quite convenient. We not cover the other modules? exports sun.security.action to java.desktop, java.security.jgss, jdk.crypto.pkcs11; Thanks Max > On Apr 20, 2016, at 10:44 PM, Claes Redestad > wrote: > > Hello, > > now that the sun.security.action package