After some internal discussions:
http://cr.openjdk.java.net/~redestad/8155039/webrev.03/
Drops the PropertiesWrapper and Properties-retrieving approach in favor of a getter
to retrieve multiple properties into a Map.
/Claes
On 2016-06-10 20:13, Mandy Chung wrote:
On Jun 10, 2016, at 4:33 AM
> On Jun 10, 2016, at 4:33 AM, Sean Mullan wrote:
>
> On 06/09/2016 10:32 PM, Mandy Chung wrote:
>> Hi Claes,
>>
>> I don’t like the PropertiesWrapper idea. The caller should be
>> cautious in storing any sensitive information. For the system
>> properties, these callsites use it in the local
On 06/09/2016 10:32 PM, Mandy Chung wrote:
Hi Claes,
I don’t like the PropertiesWrapper idea. The caller should be
cautious in storing any sensitive information. For the system
properties, these callsites use it in the local scope that I don’t
see any reason and benefit to introduce a wrapper.
Hi Claes,
I don’t like the PropertiesWrapper idea. The caller should be cautious in
storing any sensitive information. For the system properties, these callsites
use it in the local scope that I don’t see any reason and benefit to introduce
a wrapper. I didn’t follow this discussion closely
Hi,
by using a non-exported type, PropertiesWrapper, to encapsulate
Properties this change makes it impossible for a JDK developer to
accidentally leak system properties outside of java.base without
breaking encapsulation. I believe that was yours and Sean's main concern
about the API changes
Hi Claes,
What's the necessary to get all system properties for just one specific
one? Can you explain more about the necessary to make the change?
Thanks,
Xuelei
On 6/8/2016 3:44 AM, Claes Redestad wrote:
> Hi,
>
> there is some lingering concern that this and related changes make it
> that m
Hi,
there is some lingering concern that this and related changes make it
that much easier to accidentally leak the system Properties object
outside of core modules. By wrapping access to the system Properties
object in a class residing in a non-exported package we disallow this at
little to
Hi,
the API this improvement depends on was updated to reflect more clearly
that this
is taking a privileged action:
https://bugs.openjdk.java.net/browse/JDK-8155775
Here's the updated webrev:
http://cr.openjdk.java.net/~redestad/8155039/webrev.01/
Thanks!
/Claes
On 2016-04-25 19:28, Cla
