Re: RFR: 8281175: Add a -providerPath option to jarsigner [v2]

2022-02-04 Thread Hai-May Chao
On Thu, 3 Feb 2022 18:32:42 GMT, Weijun Wang wrote: >> Add the `-providerPath` option to jarsigner to be consistent with keytool. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > no need to append to null Marked as reviewed

Re: RFR: 8281175: Add a -providerPath option to jarsigner [v2]

2022-02-03 Thread Weijun Wang
On Thu, 3 Feb 2022 19:11:17 GMT, Hai-May Chao wrote: > Code change looks good to me. > I have a comment on the CSR. The “Options for jarsigner” section in > `jarsigner` manpage, where it describes `-digestalg algorithm` and `-sigalg > algorithm`, we would update it to include this new option `-

Re: RFR: 8281175: Add a -providerPath option to jarsigner [v2]

2022-02-03 Thread Hai-May Chao
On Thu, 3 Feb 2022 18:32:42 GMT, Weijun Wang wrote: >> Add the `-providerPath` option to jarsigner to be consistent with keytool. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > no need to append to null Code change looks g

Re: RFR: 8281175: Add a -providerPath option to jarsigner [v2]

2022-02-03 Thread Weijun Wang
> Add the `-providerPath` option to jarsigner to be consistent with keytool. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: no need to append to null - Changes: - all: https://git.openjdk.java.net/jdk/pull/7338/files