On Sat, 9 Apr 2022 15:00:46 GMT, Weijun Wang wrote:
>>> You might try it on other objects:
>>
>> Nice idea to test object collection. I added two test cases.
>>
>>> The `NativeGSSContext` code still needs to be fixed.
>>
>> Could you have more details? I did not catch the comment about
>>
On Sat, 9 Apr 2022 06:22:51 GMT, Xue-Lei Andrew Fan wrote:
> Could you have more details? I did not catch the comment about
> NativeGSSContext.
When `NativeGSSContext(GSSNameElement peer, GSSCredElement myCred, int time,
GSSLibStub stub)` is called, `pContext` is 0 and you haven't registered
On Fri, 8 Apr 2022 13:50:25 GMT, Weijun Wang wrote:
> You might try it on other objects:
Nice idea to test object collection. I added two test cases.
> The `NativeGSSContext` code still needs to be fixed.
Could you have more details? I did not catch the comment about
NativeGSSContext.
On Fri, 8 Apr 2022 13:50:25 GMT, Weijun Wang wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> @bchristi-git showed me this test. You might try it on other objects:
>
> import
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 20:00:00 GMT, Weijun Wang wrote:
> I'm not sure if it's possible to write a test on the cleanup, but at least we
> can temporarily add a `println` line there and see if it ever gets called.
I did not find a way to test cleanup yet. Yes, a temporary 'println" is what I
can
On Thu, 7 Apr 2022 19:21:31 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the
>> java.security.jgss module. It is one of the efforts to clean up the use of
>> finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally
On Thu, 7 Apr 2022 17:54:35 GMT, Xue-Lei Andrew Fan wrote:
>> Hmm, the earlier JCE change would also needs to be updated as it calls a
>> cleanup method on the to-be-cleaned object.
>
>> Hmm, the earlier JCE change would also needs to be updated as it calls a
>> cleanup method on the
> Please review the update to remove finalizer method in the java.security.jgss
> module. It is one of the efforts to clean up the use of finalizer method in
> JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
Update
11 matches
Mail list logo
