On Fri, 15 Apr 2022 18:48:33 GMT, Brent Christian wrote:
>>> CleanerFactory is in java.base module, and does not export to
>>> jdk.crypto.cryptoki module. I'm not sure if adding modules dependency is
>>> good or not.
>
> It seems fine to me to export the common Cleaner to
On Fri, 15 Apr 2022 15:00:18 GMT, Xue-Lei Andrew Fan wrote:
> > CleanerFactory is in java.base module, and does not export to
> > jdk.crypto.cryptoki module. I'm not sure if adding modules dependency is
> > good or not.
It seems fine to me to export the common Cleaner to
On Fri, 15 Apr 2022 08:25:40 GMT, Daniel Fuchs wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't use lambda in cleaner
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java
>
On Fri, 15 Apr 2022 13:32:10 GMT, altrisi wrote:
> Can't this use `CleanerFactory.cleaner()` and reuse the common Cleaner
> instead of having its own?
CleanerFactory is in java.base module, and does not export to
jdk.crypto.cryptoki module. I'm not sure if adding modules dependency is good
On Fri, 15 Apr 2022 07:20:42 GMT, Xue-Lei Andrew Fan wrote:
>> This is an effort to fix a problem introduced in the fix for
>> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
>> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However,
>> there is a
On Fri, 15 Apr 2022 07:20:42 GMT, Xue-Lei Andrew Fan wrote:
>> This is an effort to fix a problem introduced in the fix for
>> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
>> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However,
>> there is a
> This is an effort to fix a problem introduced in the fix for
> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which
> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, there
> is a problem with the code changes. The Runnables registered with Cleaner
>
