On Tue, 26 Apr 2022 21:02:49 GMT, Weijun Wang wrote:
> Only numbers from the same modular fields can be involved in arithmetic
> calculations. Add `assert` to guarantee this.
>
> Also, found one broken case and rewrote it.
Changes look good
-
Marked as reviewed by ascarpino
On Tue, 26 Apr 2022 21:02:49 GMT, Weijun Wang wrote:
> Only numbers from the same modular fields can be involved in arithmetic
> calculations. Add `assert` to guarantee this.
>
> Also, found one broken case and rewrote it.
Please update bug with applicable noreg label.
-
PR:
On Wed, 27 Apr 2022 12:57:20 GMT, Weijun Wang wrote:
>> src/jdk.crypto.ec/share/classes/sun/security/ec/ECDSAOperations.java line
>> 261:
>>
>>> 259: IntegerModuloP result = p1.asAffine().getX();
>>> 260: b2a(result, orderField, temp1);
>>> 261: return
On Tue, 26 Apr 2022 21:02:49 GMT, Weijun Wang wrote:
> Only numbers from the same modular fields can be involved in arithmetic
> calculations. Add `assert` to guarantee this.
>
> Also, found one broken case and rewrote it.
Marked as reviewed by xuelei (Reviewer).
-
PR:
On Wed, 27 Apr 2022 06:28:27 GMT, Xue-Lei Andrew Fan wrote:
>> Only numbers from the same modular fields can be involved in arithmetic
>> calculations. Add `assert` to guarantee this.
>>
>> Also, found one broken case and rewrote it.
>
>
On Tue, 26 Apr 2022 21:02:49 GMT, Weijun Wang wrote:
> Only numbers from the same modular fields can be involved in arithmetic
> calculations. Add `assert` to guarantee this.
>
> Also, found one broken case and rewrote it.
src/jdk.crypto.ec/share/classes/sun/security/ec/ECDSAOperations.java
