wrote:
Thanks for review Xuelei, I will incorporate your suggestions.
Thanks,
Prasad.K
-Original Message-
From: Xuelei Fan
Sent: Thursday, April 2, 2020 9:12 PM
To: security-dev@openjdk.java.net
Subject: Re: RFR[jdk] 8237474: Default SSLEngine should create in server role
Please upda
Thanks for review Xuelei, I will incorporate your suggestions.
Thanks,
Prasad.K
> -Original Message-
> From: Xuelei Fan
> Sent: Thursday, April 2, 2020 9:12 PM
> To: security-dev@openjdk.java.net
> Subject: Re: RFR[jdk] 8237474: Default SSLEngine should create in server r
Please update copyright year to 2020.
SSLEngine.java
--
@@ -1109,10 +1115,14 @@
+ * @implNote
+ * The JDK SunJSSE provider implementation returns false unless
{@link setUseClientMode}
+ * is used to change the mode to true.
For the link, I may add parameter, an
Gentle ping?
Thanks,
Prasad.K
From: Prasadrao Koppula
Sent: Monday, March 30, 2020 7:21 PM
To: security-dev@openjdk.java.net
Subject: RE: RFR[jdk] 8237474: Default SSLEngine should create in server role
Hi,
Added @implnote and updated test changes, here is the new webrev, please
Hi,
Added @implnote and updated test changes, here is the new webrev, please review
it.
Webrev: http://cr.openjdk.java.net/~pkoppula/8237474/webrev.01/
issue: https://bugs.openjdk.java.net/browse/JDK-8237474
CSR: https://bugs.openjdk.java.net/browse/JDK-8238593
Thanks,
Prasad.
> -Original Message-
> From: Daniel Fuchs
> Sent: Friday, February 7, 2020 8:32 PM
> To: Prasadrao Koppula ; Sean Coffey
> ; security-dev@openjdk.java.net
> Subject: Re: RFR[jdk] 8237474: Default SSLEngine should create in server role
>
> Hi Prasad,
>
>
Hi Prasad,
On 07/02/2020 14:28, Prasadrao Koppula wrote:
Thanks for review Sean, I will add test changes.
Not a review - but I just wanted to double check that
you have run the :jdk_net tests too - especially the
httpclient tests (which are part of :jdk_net) as the
httpclient is a heavy user o
Thanks for review Sean, I will add test changes.
Thanks,
Prasad.K
From: Seán Coffey
Sent: Friday, February 7, 2020 6:20 PM
To: Prasadrao Koppula ;
security-dev@openjdk.java.net
Subject: Re: RFR[jdk] 8237474: Default SSLEngine should create in server role
Looks ok to me Prasad. This
Looks ok to me Prasad. This may also be worthy of highlighting via
release note. You might be able to expand test coverage to capture the
TLSContext scenario. Something like below patch might work ?
---
a/test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java
+++
b/test/jdk/
