Re: RFR 8054817: File ccache only recognizes Linux and Solaris defaults

2014-08-19 Thread Michael Osipov
Am 2014-08-11 um 16:14 schrieb Wang Weijun: Please review the fix at http://cr.openjdk.java.net/~weijun/8054817/webrev.00 since we have a new getuid() now for all Unix systems. It does return -1 on Windows, but I keep the osname.startsWith("Windows") check to be exactly consistent with the cur

Re: RFR 8054817: File ccache only recognizes Linux and Solaris defaults

2014-08-18 Thread Sean Mullan
Looks fine to me. Do you still need to import java.lang.reflect.* though? --Sean On 08/11/2014 10:14 AM, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8054817/webrev.00 since we have a new getuid() now for all Unix systems. It does return -1 on Windows, b