Re: RFR 8164437: Test for JDK-8042900

2016-08-19 Thread Xuelei Fan
OK. Xuelei On 8/19/2016 7:47 PM, Weijun Wang wrote: On 8/19/2016 16:48, Xuelei Fan wrote: Looks fine to me. BTW, why not check the class name right after the object is created? This is just a small enhancement to an existing test, and I don't want to break the existing block. I added a com

Re: RFR 8164437: Test for JDK-8042900

2016-08-19 Thread Weijun Wang
On 8/19/2016 16:48, Xuelei Fan wrote: Looks fine to me. BTW, why not check the class name right after the object is created? This is just a small enhancement to an existing test, and I don't want to break the existing block. I added a comment there. And I've enhanced the test a little to c

Re: RFR 8164437: Test for JDK-8042900

2016-08-19 Thread Xuelei Fan
Looks fine to me. BTW, why not check the class name right after the object is created? Xuelei On 8/19/2016 2:34 PM, Weijun Wang wrote: Please review the code change at http://cr.openjdk.java.net/~weijun/8164437/webrev.00 The updated test shows that with the jdk.security.jgss package, the