Re: RFR 8168979: @implNote for invalid FilePermission

2016-12-13 Thread Wang Weijun
> On Dec 14, 2016, at 10:11 AM, Xuelei Fan wrote: > > On 12/13/2016 5:45 PM, Wang Weijun wrote: >> A major behavior change is that <> now implies an invalid >> permission, I hope this is good to minimize incompatibility. > Looks like two sides of the same coin. If there is an invalid <> > (no

Re: RFR 8168979: @implNote for invalid FilePermission

2016-12-13 Thread Xuelei Fan
On 12/13/2016 5:45 PM, Wang Weijun wrote: A major behavior change is that <> now implies an invalid permission, I hope this is good to minimize incompatibility. Looks like two sides of the same coin. If there is an invalid > (not existing in practice, I think), it now implies all; if no

Re: RFR 8168979: @implNote for invalid FilePermission

2016-12-13 Thread Wang Weijun
Webrev updated at http://cr.openjdk.java.net/~weijun/8168979/webrev.01 One comment is moved to its correct position and a typo fixed. Thanks Daniel for the comment. Can someone with a reviewer hat take a look? Thanks Max > On Dec 12, 2016, at 6:03 PM, Daniel Fuchs wrote: > > Hi Max, > >

Re: RFR 8168979: @implNote for invalid FilePermission

2016-12-12 Thread Wang Weijun
> On Dec 12, 2016, at 6:03 PM, Daniel Fuchs wrote: > > Hi Max, > > Don't count me as reviewer - but I see a mismatched comment > in the file: > > 209 /** > 210 * Creates FilePermission objects with special internals. > 211 * See {@link FilePermCompat#newPermPlusAltPath(Permission

Re: RFR 8168979: @implNote for invalid FilePermission

2016-12-12 Thread Daniel Fuchs
Hi Max, Don't count me as reviewer - but I see a mismatched comment in the file: 209 /** 210 * Creates FilePermission objects with special internals. 211 * See {@link FilePermCompat#newPermPlusAltPath(Permission)} and 212 * {@link FilePermCompat#newPermUsingAltPath(Permiss