Re: RFR 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304

2016-11-21 Thread Amanda Jiang
Hi Max, Thanks for your comments, the webrev below addressed all the issues you mentioned, please check and let me know if there are any problem. http://cr.openjdk.java.net/~amjiang/8169911/webrev.02/ Thanks, Amanda On 11/18/16 11:37 PM, Wang Weijun wrote: Hi Amanda - There are many

Re: RFR 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304

2016-11-18 Thread Wang Weijun
Hi Amanda - There are many duplicates in signWithAlias() and sign(). I think it's better to make one based on the other. Maybe signWithAliasAndTsa() and sign(). - checkWeak2() is about combinations of weak/strong algs in a single signer. I'd rather it be an individual test case, and not as a