Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-12-13 Thread Sean Mullan
Looks ok to me. --Sean On 12/4/19 9:49 PM, Weijun Wang wrote: Ping the security side. On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: Build change looks good. /Erik On 2019-11-22 18:59, Weijun Wang wrote: Please review the change at http://cr.openjdk.java.net/~weijun/8234697/webr

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-12-04 Thread Weijun Wang
Ping the security side. > On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: > > Build change looks good. > > /Erik > > On 2019-11-22 18:59, Weijun Wang wrote: >> Please review the change at >> >>http://cr.openjdk.java.net/~weijun/8234697/webrev.00/ >> >> The new lines in Gensrc-java.bas

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-27 Thread Weijun Wang
> On Nov 27, 2019, at 9:44 PM, Erik Joelsson wrote: > > On 2019-11-26 16:39, Weijun Wang wrote: >> >>> On Nov 27, 2019, at 12:14 AM, Erik Joelsson >>> wrote: >>> >>> On 2019-11-25 16:42, Weijun Wang wrote: > On Nov 26, 2019, at 12:36 AM, Erik Joelsson > wrote: > > Build

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-27 Thread Erik Joelsson
On 2019-11-26 16:39, Weijun Wang wrote: On Nov 27, 2019, at 12:14 AM, Erik Joelsson wrote: On 2019-11-25 16:42, Weijun Wang wrote: On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: Build change looks good. Thanks. One question: I see the output to stdout from FieldGen.java shown in buil

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-26 Thread Weijun Wang
> On Nov 27, 2019, at 12:14 AM, Erik Joelsson wrote: > > On 2019-11-25 16:42, Weijun Wang wrote: >> >>> On Nov 26, 2019, at 12:36 AM, Erik Joelsson >>> wrote: >>> >>> Build change looks good. >> Thanks. >> >> One question: I see the output to stdout from FieldGen.java shown in build. >>

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-26 Thread Erik Joelsson
On 2019-11-25 16:42, Weijun Wang wrote: On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: Build change looks good. Thanks. One question: I see the output to stdout from FieldGen.java shown in build. Is it possible to hide it but still store the output in the log file? No, we are not abl

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-25 Thread Weijun Wang
> On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: > > Build change looks good. Thanks. One question: I see the output to stdout from FieldGen.java shown in build. Is it possible to hide it but still store the output in the log file? I copied everything from CLDR_GEN_DONE but that one do

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-25 Thread Erik Joelsson
Build change looks good. /Erik On 2019-11-22 18:59, Weijun Wang wrote: Please review the change at http://cr.openjdk.java.net/~weijun/8234697/webrev.00/ The new lines in Gensrc-java.base.gmk mimics the one for CLDR_GEN_DONE at the beginning of the same file. I changed the BigInteger par