Re: RFR JDK-8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError

2018-12-06 Thread Xue-Lei Fan
Looks fine to me. Thanks, Xuelei On 12/6/2018 1:09 PM, Jamil Nimeh wrote: Hello everyone, Updates from Xuelei's comments have been folded into an updated webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8214129/webrev.02/ Thank you, --Jamil On 12/5/18 3:59 PM, Jamil Nimeh wrote: Hello a

Re: RFR JDK-8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError

2018-12-06 Thread Jamil Nimeh
Hello everyone, Updates from Xuelei's comments have been folded into an updated webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8214129/webrev.02/ Thank you, --Jamil On 12/5/18 3:59 PM, Jamil Nimeh wrote: Hello all, This fix covers an issue where large numbers of TLS 1.2 session resumpt

Re: RFR JDK-8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError

2018-12-06 Thread Jamil Nimeh
I will change those additional spots in the code.  Glad you caught those.  I think also your suggestion about a comment on those locations in the code makes sense. --Jamil On 12/5/2018 8:20 PM, Xue-Lei Fan wrote: Hi Jamil, For a defense in depth fix, as you are already there, I may suggest

Re: RFR JDK-8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError

2018-12-05 Thread Xue-Lei Fan
Hi Jamil, For a defense in depth fix, as you are already there, I may suggest update two more places. ServerNameExtension.java: private CHServerNamesSpec(List serverNames) { this.serverNames = Collections.unmodifiableList(serverNames); } SSLSession